DRILL-1942-readers: #154
Closed
DRILL-1942-readers: #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 LGTM. |
cwestin
force-pushed
the
alloc-readers
branch
from
2b23db2 to
2e0e02a
Compare
amansinha100
pushed a commit
to amansinha100/drill
that referenced
this pull request
Sep 16, 2015
- add extends AutoCloseable to RecordReader, and rename cleanup() to close(). - fix many warnings - formatting fixes DRILL-1942-readers: - renamed cleanup() to close in the new JdbcRecordReader Close apache#154
- add extends AutoCloseable to RecordReader, and rename cleanup() to close(). - fix many warnings - formatting fixes
- renamed cleanup() to close in the new JdbcRecordReader
cwestin
force-pushed
the
alloc-readers
branch
from
2e0e02a to
7233e64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unit tests pass
presubmit regression and customer passes
presubmit tpc-h SF100 passes